New up-to-date review of french readme + note of when it was last reviewed #3142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@bilhox it's actually very similar to what I did, I only added an header line before. would you not agree it would be fitting? |
Contributor
Author
yes, just add also an english version of the date like I did. |
TheRealGabHas
left a comment
TheRealGabHas
left a comment
There was a problem hiding this comment.
I think all the changes are good, they make the reading process more natural.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an up-to-date review of my french translation created a year ago, I mainly changed some wording I was using which wasn't natural, and more importantly, I added a note at the end of the file saying when it was last reviewed.