-
-
Notifications
You must be signed in to change notification settings - Fork 185
Add Italian README #3120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Italian README #3120
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, LGTM.
On the general issue of readmes being out of date - I think that is OK as long as we have a policy of making people aware in each translation that the translated readmes will often lag behind the English 'main' version. I think we should probably feature a general disclaimer at the top, and a date at which the translation was last matched/updated to the English readme.
After all, at the minute our Italian readme is 100% incorrect because it doesn't exist at all, adding a translated readme can only improve that situation.
What about just adding when the readme translation was last reviewed at the end of the file ? |
Should I add this? |
Yes. |
is this good enough? (you can display the rich diff in the new file to see how it looks) |
I'm going to open a PR for french translation so you can understand what I'm expecting. |
Alright, I added the last reviewed tag and fixed the italian text |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I can see you updated the text after itzpredator suggestions.
I am aware that @Starbuck5 wants to enhance the readme (and I can see why), but I saw some new readmes added recently so I thought I might aswell submit the italian one now. It won't be a problem to update it once it's needed.
For quite obvious reasons I required the review of Alberto (I don't think there's any other italian member).