Skip to content

Add Italian README #3120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 8, 2024
Merged

Add Italian README #3120

merged 6 commits into from
Oct 8, 2024

Conversation

damusss
Copy link
Member

@damusss damusss commented Sep 25, 2024

I am aware that @Starbuck5 wants to enhance the readme (and I can see why), but I saw some new readmes added recently so I thought I might aswell submit the italian one now. It won't be a problem to update it once it's needed.

For quite obvious reasons I required the review of Alberto (I don't think there's any other italian member).

@damusss damusss added the docs label Sep 25, 2024
@damusss damusss requested a review from itzpr3d4t0r September 25, 2024 13:40
@damusss damusss requested a review from a team as a code owner September 25, 2024 13:40
@bilhox bilhox added this to the 2.5.2 milestone Oct 3, 2024
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, LGTM.

On the general issue of readmes being out of date - I think that is OK as long as we have a policy of making people aware in each translation that the translated readmes will often lag behind the English 'main' version. I think we should probably feature a general disclaimer at the top, and a date at which the translation was last matched/updated to the English readme.

After all, at the minute our Italian readme is 100% incorrect because it doesn't exist at all, adding a translated readme can only improve that situation.

@bilhox
Copy link
Contributor

bilhox commented Oct 3, 2024

What about just adding when the readme translation was last reviewed at the end of the file ?

@damusss
Copy link
Member Author

damusss commented Oct 5, 2024

What about just adding when the readme translation was last reviewed at the end of the file ?

Should I add this?

@MyreMylar
Copy link
Member

What about just adding when the readme translation was last reviewed at the end of the file ?

Should I add this?

Yes.

@damusss
Copy link
Member Author

damusss commented Oct 5, 2024

Yes.

is this good enough? (you can display the rich diff in the new file to see how it looks)

@bilhox
Copy link
Contributor

bilhox commented Oct 5, 2024

I'm going to open a PR for french translation so you can understand what I'm expecting.

@damusss
Copy link
Member Author

damusss commented Oct 5, 2024

Alright, I added the last reviewed tag and fixed the italian text

Copy link
Contributor

@bilhox bilhox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I can see you updated the text after itzpredator suggestions.

@bilhox bilhox merged commit 8ee07ff into pygame-community:main Oct 8, 2024
3 checks passed
@damusss damusss deleted the italian-readme branch October 8, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants