Fix editable install on windows #3117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankith26
force-pushed
the
ankith26-fix-editable
branch
from
18a496c to
54487ce
Compare
|
I just tested this on a fresh Windows 11 VM and it seems to work okay |
ankith26
commented
Sep 23, 2024
gresm
reviewed
Sep 23, 2024
ankith26
force-pushed
the
ankith26-fix-editable
branch
from
54487ce to
d35a672
Compare
|
While this strategy works, I believe it can be improved further. I'll experiment with this a bit more. |
ankith26
force-pushed
the
ankith26-fix-editable
branch
from
d35a672 to
9a2c587
Compare
ankith26
force-pushed
the
ankith26-fix-editable
branch
from
9a2c587 to
98170b3
Compare
|
Okay, I think this PR should be done from my side. The new strategy basically makes the meson buildconfig keep track of the DLL dirs in a JSON file, and then at runtime this file can be handled if it is available (in the editable case only) |
bilhox
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An (untested) attempt to making editable installs work on windows.
Basically the idea is to special case the DLL handling code which already exists, to handle editable installs differently. With an editable install no DLL moving happens, so we just have to hunt for the DLLs in the source tree and track the folders.