Skip to content

release machinery: fix attestation and circleci #3040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

ankith26
Copy link
Member

@ankith26 ankith26 commented Aug 6, 2024

In the latest 2.5.1dev2 release we hit a few hiccups with the release machinery

  1. The old circleci auto-cancel issue: I have implemented a workaround this time that should (hopefully) work.
  2. A new issue where the pypi uploader failed: this is a result of Improve security of releases by adding hash checks #2941 not working as I had expected it to. I have now implemented a new strategy that should serve the same purpose, but works differently. It uses the new github attestations thingy. This time, I'm gonna test out this approach in a separate repo first before merging this PR (I will post links to the status here)

@ankith26 ankith26 requested a review from a team as a code owner August 6, 2024 12:44
@ankith26 ankith26 force-pushed the ankith26-release-machinery branch from 7ece24c to f64cb40 Compare August 6, 2024 12:46
@ankith26 ankith26 force-pushed the ankith26-release-machinery branch from f64cb40 to 2640077 Compare August 6, 2024 18:11
@ankith26
Copy link
Member Author

ankith26 commented Aug 6, 2024

I made a repo to test what I implemented in this PR: https://github.com/ankith26/testing-attestations

@ankith26 ankith26 added this to the 2.5.1 milestone Aug 7, 2024
@Starbuck5
Copy link
Member

So if I add a new wheel to the GH release before publishing it, the workflow will ignore it?

@ankith26
Copy link
Member Author

ankith26 commented Aug 7, 2024

Yes, that is the plan. You cannot add or modify any wheel in the github release and then expect the system to release it on PyPI going forward. This is because members have access to the github release and can push arbitrary stuff to it.

If we ever have a requirement of pushing wheels manually, we must now push it to PyPI manually (at the moment only me, you and myre can do it)

Copy link
Member

@Starbuck5 Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay let's try it out.

@ankith26 ankith26 merged commit 8e0c592 into main Aug 7, 2024
22 checks passed
@ankith26 ankith26 deleted the ankith26-release-machinery branch August 7, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants