Skip to content

Skip flaky window tests on pypy #3017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 23, 2024
Merged

Skip flaky window tests on pypy #3017

merged 1 commit into from
Jul 23, 2024

Conversation

ankith26
Copy link
Member

Until we figure out the cause of the fails, it is better to skip these fails.

LMK if I have missed any other test in this file that's also flaky on pypy

@ankith26 ankith26 requested a review from a team as a code owner July 23, 2024 08:49
damusss
damusss approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@damusss damusss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember any other tests. They fail pretty often, so this is a good idea for the time being IMO.
LGTM :)

oddbookworm
oddbookworm approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@oddbookworm oddbookworm left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I’ve seen these occasionally fail on non-pypy runs, but I couldn’t guarantee that right now. Let’s see what happens

@oddbookworm oddbookworm added this to the 2.5.1 milestone Jul 23, 2024
@oddbookworm oddbookworm added CI Issue with the Continuous Integration (CI), the actions/bots that test things pypy window pygame.Window labels Jul 23, 2024
@oddbookworm oddbookworm merged commit 0547247 into main Jul 23, 2024
24 checks passed
@oddbookworm oddbookworm deleted the ankith26-window-pypy branch July 23, 2024 11:19
@ankith26 ankith26 mentioned this pull request Aug 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oddbookworm oddbookworm oddbookworm approved these changes

@damusss damusss damusss approved these changes

Assignees
No one assigned
Labels
CI Issue with the Continuous Integration (CI), the actions/bots that test things pypy window pygame.Window
Projects
None yet
Milestone
2.5.1
Development

Successfully merging this pull request may close these issues.
3 participants
@ankith26 @oddbookworm @damusss