Skip to content

Use static inline instead of inline #2952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2024
Merged

Use static inline instead of inline #2952

merged 1 commit into from
Jun 30, 2024

Conversation

zoldalma999
Copy link
Member

@zoldalma999 zoldalma999 commented Jun 23, 2024 •
edited by ankith26
Loading

Note by @ankith26 as for why this PR is needed: This fixes gcc/mingw compilation failures when pygame is compiled with debug flags

@zoldalma999 zoldalma999 requested a review from a team as a code owner June 23, 2024 11:29
ankith26
ankith26 approved these changes Jun 23, 2024
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR 🎉

@yunline yunline added the Code quality/robustness Code quality and resilience to changes label Jun 24, 2024
damusss
damusss approved these changes Jun 30, 2024
View reviewed changes
Copy link
Member

@damusss damusss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@damusss damusss merged commit c6c7d20 into pygame-community:main Jun 30, 2024
39 checks passed
@damusss damusss added this to the 2.5.1 milestone Jun 30, 2024
@zoldalma999 zoldalma999 deleted the use-static-inline branch October 22, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankith26 ankith26 ankith26 approved these changes

@damusss damusss damusss approved these changes

Assignees
No one assigned
Labels
Code quality/robustness Code quality and resilience to changes
Projects
None yet
Milestone
2.5.1
Development

Successfully merging this pull request may close these issues.
4 participants
@zoldalma999 @ankith26 @damusss @yunline