Skip to content

Very small typehint fix for pygame.Mask #2926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2024
Merged

Very small typehint fix for pygame.Mask #2926

merged 1 commit into from
Jun 15, 2024

Conversation

damusss
Copy link
Member

@damusss damusss commented Jun 14, 2024

That method returns a list of rects not necessarily one.

@damusss damusss requested a review from a team as a code owner June 14, 2024 19:49
ankith26
ankith26 approved these changes Jun 15, 2024
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR 😎

@ankith26 ankith26 added this to the 2.5.1 milestone Jun 15, 2024
MyreMylar
MyreMylar approved these changes Jun 15, 2024
View reviewed changes
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MyreMylar MyreMylar merged commit 13bc034 into pygame-community:main Jun 15, 2024
36 checks passed
@damusss damusss deleted the mask-typehint-fix branch June 18, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MyreMylar MyreMylar MyreMylar approved these changes

@ankith26 ankith26 ankith26 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.1
Development

Successfully merging this pull request may close these issues.
3 participants
@damusss @MyreMylar @ankith26