Skip to content

Add license identifier to readme #2890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Conversation

MyreMylar
Copy link
Member

fixes #1737

I know @Starbuck5 wants to rewrite the readme anyway, but I thought I'd toss this into the pot as a thing to clarify.

The debate here would be between the two variants:

  • LGPL-2.1-only
  • LGPL-2.1-or-later

I have no strong feelings on this topic but I can see why some users might want it clarified for legal reasons.

@MyreMylar MyreMylar added the docs label May 30, 2024
@MyreMylar MyreMylar requested a review from a team as a code owner May 30, 2024 13:39
Copy link
Member

@andrewhong04 andrewhong04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MyreMylar
Copy link
Member Author

I should note that @ankith26 expressed a preference on discord for LGPL-2.1-only on the basis that it is the effective status quo.

As I said before I don't really mind either way this was originally raised by @ruben2020 so perhaps they have stronger feelings on the topic.

@ruben2020
Copy link

@MyreMylar If you're fine either way, I would recommend LGPL-2.1-or-later as it is more flexible for users than LGPL-2.1-only.

@ankith26
Copy link
Member

ankith26 commented Jul 8, 2024

We do have a restriction of not changing the terms of the license, and I don't want this PR to be interpreted as so.

Hence I believe we are more or less forced to maintain status quo, and I believe LGPL-2.1-only achieves it, even though technically both LGPL-2.1-only and LGPL-2.1-or-later have identical license text (which is what creates this confusion in the first place).

I would like to hear @Starbuck5 s opinions here to settle the matter

@Starbuck5
Copy link
Member

Starbuck5 commented Jul 11, 2024

I'm fine to go 2.1-or-later.

Thoughts:

  • My theory was that Pete Shinners chose this license because it's the same one as SDL1 used. Looking at SDL1, they almost always refer to it as the "LPGL", not "LPGL v2", so the spirit of the "or later" is there.
  • This is a matter up to interpretation, so it's fine for us to interpret it this way
  • This is somewhat academic, will not make a difference to many people (if it makes a difference to anyone)

@ankith26 ankith26 added this to the 2.5.1 milestone Jul 16, 2024
@ankith26 ankith26 merged commit 31a2df0 into main Jul 16, 2024
3 checks passed
@ankith26 ankith26 deleted the add-license-identifier-to-readme branch July 16, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please clarify license in README (3521)
5 participants