-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLEND_OVERLAY
blend mode
#2377
base: main
Are you sure you want to change the base?
BLEND_OVERLAY
blend mode
#2377
Conversation
fa4d7f1
to
bae0f50
Compare
32cc801
to
cb22741
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this all seems to work OK, the tests make sense and I'm convinced that it has value as a blend mode.
Only two things lacking really:
- An SSE2/NEON version for decent performance on macs/arm.
- Documentation on the special flags page - ideally we should include the formula in this one as it is more complicated than the existing set of MUL, ADD & SUB blend modes. Something like the description on the wikipedia page:
Would help I think.
I think we could have the SSE2 version in another PR - because there will at least be a version for all platforms after this one, but we definitely need the docs or nobody will know it exists.
a1db406
to
c241743
Compare
Since this has been up for a long time I've also added the SSE2 RGB blitter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes #2373, featuring:
BLEND_OVERLAY
andBLEND_RGB_OVERLAY
flags and algorithm with:For a visual test i'm using the following image and program:
