Don't use SDL_ name for our compat layer #2356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starbuck5
added
Code quality/robustness
This actually bit me when I tried to compile pygame-ce on a mac running 2.0.21, which has the symbol SDL_IntersectFRectAndLine. The compilation failed because of the duplicate symbol.
Starbuck5
force-pushed
the
lineintersect-patch
branch
from
b4c0e97 to
6651f56
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This actually bit me when I tried to compile pygame-ce on a mac running 2.0.21, which has the symbol SDL_IntersectFRectAndLine. The compilation failed because of the duplicate symbol.