Skip to content

removed pygame.cdrom refs everywhere #2327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zoldalma999 merged 3 commits into from
Jul 22, 2023
Merged

removed pygame.cdrom refs everywhere #2327

zoldalma999 merged 3 commits into from
Jul 22, 2023

Conversation

@oddbookworm
Copy link
Member

@oddbookworm oddbookworm commented Jul 19, 2023

Resolves #2323

@oddbookworm oddbookworm added docs tests tests (module) cdrom pygame.cdrom labels Jul 19, 2023
@oddbookworm oddbookworm requested a review from a team as a code owner July 19, 2023 01:24
Starbuck5
Starbuck5 approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@Starbuck5 Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

MightyJosip
MightyJosip reviewed Jul 19, 2023
View reviewed changes
ankith26
ankith26 reviewed Jul 20, 2023
View reviewed changes
zoldalma999
zoldalma999 approved these changes Jul 22, 2023
View reviewed changes
Copy link
Member

@zoldalma999 zoldalma999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@zoldalma999 zoldalma999 merged commit 17cb435 into pygame-community:main Jul 22, 2023
@ankith26 ankith26 added this to the 2.3.1 milestone Jul 26, 2023
@zoldalma999 zoldalma999 mentioned this pull request Aug 21, 2023
Merged
@oddbookworm oddbookworm deleted the remove_cdrom branch December 21, 2023 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MightyJosip MightyJosip MightyJosip left review comments

@ankith26 ankith26 ankith26 left review comments

@Starbuck5 Starbuck5 Starbuck5 approved these changes

@zoldalma999 zoldalma999 zoldalma999 approved these changes

Assignees

No one assigned

Labels

cdrom pygame.cdrom docs tests tests (module)

Projects

None yet

Milestone

2.3.1

Development

Successfully merging this pull request may close these issues.

Remove all traces of pygame.cdrom?

5 participants

@oddbookworm @MightyJosip @Starbuck5 @zoldalma999 @ankith26