Skip to content

Fix theme icon positioning when the page shrinks (fix #2320) #2321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

devdanzin
Copy link
Contributor

@devdanzin devdanzin commented Jul 15, 2023

Fix the theme icon positioning by moving both images into the searchbar-container div. Fixes #2320.

fixed_theme_icon

@devdanzin devdanzin requested a review from a team as a code owner July 15, 2023 12:28
Copy link
Member

@Starbuck5 Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This look good to me, thanks for handling this!

@Notenlish does this seem fine to you?

@Starbuck5 Starbuck5 added the docs label Jul 16, 2023
@Notenlish
Copy link
Contributor

This look good to me, thanks for handling this!

@Notenlish does this seem fine to you?

Yeah

Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contributing to pygame-ce! 🥳

@ankith26 ankith26 added this to the 2.3.1 milestone Jul 17, 2023
@ankith26 ankith26 merged commit 2e864cd into pygame-community:main Jul 17, 2023
@devdanzin devdanzin deleted the fix_theme_icon branch July 17, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark mode icon behaves strangely when page shrinks
4 participants