Raise an error when source and destination surfaces are the same (in box_blur and gaussian_blur).
#2161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when source and destination surfaces are the same.
Matiiss
requested changes
May 18, 2023
Member
Matiiss
left a comment
Matiiss
left a comment
There was a problem hiding this comment.
This should probably have a note in the docs that passing the calling surface as destination surface would raise an exception. Otherwise looks good to me.
Starbuck5
reviewed
May 20, 2023
Starbuck5
reviewed
May 21, 2023
Starbuck5
approved these changes
May 21, 2023
Member
Starbuck5
left a comment
Starbuck5
left a comment
There was a problem hiding this comment.
Left some error message feedback to resolve before merge, otherwise looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue from #2103
Fix #2102