Undocument and deprecate redundant sprite group classes #2036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To clean up the sprite documentation I've removed three classes that do nothing. I've also removed OrderedUpdates from the code, it became effectively redundant after we dropped Python 3.5 support and all dictionaries became ordered. Ordered dictionaries were then made part of the Python specification in version 3.7 which is currently our lowest supported version.
yunline
added
enhancement
sprite
ankith26
approved these changes
Mar 21, 2023
Member
ankith26
left a comment
ankith26
left a comment
There was a problem hiding this comment.
Nice cleanups, this indeed looks like the way forward, thanks for the PR 🍰
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To clean up the sprite documentation I've removed three classes that do nothing.
I've also removed
OrderedUpdatesfrom the sprite group code, it became effectively redundant after we dropped Python 3.5 support and all dictionaries became ordered. Ordered dictionaries were then made part of the Python specification in version 3.7 which is currently our lowest supported version.Related to: #1941