Skip to content

Conversation

@itzpr3d4t0r
Copy link
Member

I renamed “the_args” to “blend_flags” because they are not regular arguments but flags for blending modes. However, I’m not sure how to handle the discrepancy between the python code and the C code. The python code expects “special_flags” as an argument name in all blit functions, but the C code uses “blend_flags” as a variable name when parsing. How should we resolve this?

@itzpr3d4t0r itzpr3d4t0r added Code quality/robustness Code quality and resilience to changes Surface pygame.Surface labels Mar 11, 2023
@itzpr3d4t0r itzpr3d4t0r requested a review from a team as a code owner March 11, 2023 12:11
@itzpr3d4t0r itzpr3d4t0r changed the title Renamed the_args to blend_flags in surface.c Renamed "the_args" to "blend_flags" in "surface.c" Mar 11, 2023
@itzpr3d4t0r itzpr3d4t0r changed the title Renamed "the_args" to "blend_flags" in "surface.c" Renamed "the_args" to "blend_flags" in surface.c Mar 11, 2023
@itzpr3d4t0r
Copy link
Member Author

itzpr3d4t0r commented Mar 11, 2023

Ok turns out I need to work on this a bit more.

@itzpr3d4t0r itzpr3d4t0r marked this pull request as draft March 11, 2023 14:58
@itzpr3d4t0r
Copy link
Member Author

itzpr3d4t0r commented Mar 11, 2023

Ok the majority of the work seems done but there are a couple files I don't know how to change:
image
Actually I think I'm fine, those files aren't tracked by git.

@itzpr3d4t0r itzpr3d4t0r marked this pull request as ready for review March 11, 2023 15:13
@oddbookworm
Copy link
Member

Actually I think I'm fine, those files aren't tracked by git.

The docs/generated directory is created by running python setup.py docs, so the html in there is fine to leave alone (run python setup.py docs --fullgeneration in the event that the changes you made to the docs aren't 100% reflected with the normal docs gen)

@oddbookworm
Copy link
Member

Here's what the modified docs page looks like when I generate locally
image

Copy link
Member

@oddbookworm oddbookworm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Blitting worked just fine after from my testing and the docs page looks fine to me

@itzpr3d4t0r itzpr3d4t0r changed the title Renamed "the_args" to "blend_flags" in surface.c Renamed "the_args" to "blend_flags" everywhere Mar 11, 2023
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MyreMylar MyreMylar added this to the 2.2 milestone Mar 12, 2023
@MyreMylar MyreMylar merged commit 3057a44 into pygame-community:main Mar 12, 2023
@itzpr3d4t0r itzpr3d4t0r deleted the rename_theargs_surfblit branch March 12, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Code quality/robustness Code quality and resilience to changes Surface pygame.Surface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants