-
-
Notifications
You must be signed in to change notification settings - Fork 216
Renamed "the_args" to "blend_flags" everywhere
#2011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renamed "the_args" to "blend_flags" everywhere
#2011
Conversation
the_args" to "blend_flags" in "surface.c"
the_args" to "blend_flags" in "surface.c"the_args" to "blend_flags" in surface.c
|
Ok turns out I need to work on this a bit more. |
The |
oddbookworm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Blitting worked just fine after from my testing and the docs page looks fine to me
the_args" to "blend_flags" in surface.cthe_args" to "blend_flags" everywhere
MyreMylar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍


I renamed “the_args” to “blend_flags” because they are not regular arguments but flags for blending modes. However, I’m not sure how to handle the discrepancy between the python code and the C code. The python code expects “special_flags” as an argument name in all blit functions, but the C code uses “blend_flags” as a variable name when parsing. How should we resolve this?