Skip to content

Another minor fblits refactor #2002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
itzpr3d4t0r merged 3 commits into from
Mar 11, 2023
Merged

Another minor fblits refactor #2002

itzpr3d4t0r merged 3 commits into from
Mar 11, 2023

Conversation

@itzpr3d4t0r
Copy link
Member

@itzpr3d4t0r itzpr3d4t0r commented Mar 8, 2023 •
edited
Loading

Removed some unnecessary inits, added a couple more comments, and reduced nesting level in one place. Renamed flags_numeric to blend_flags. flags_numeric was just inherited from blits and was meant to differentiate from the python flag object pointer, but that's not a thing in fblits hence the rename.

@itzpr3d4t0r itzpr3d4t0r requested a review from a team as a code owner March 8, 2023 17:24
Starbuck5
Starbuck5 approved these changes Mar 10, 2023
View reviewed changes
Copy link
Member

@Starbuck5 Starbuck5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, seems fine 👍

@Starbuck5 Starbuck5 added Code quality/robustness Code quality and resilience to changes Surface pygame.Surface labels Mar 10, 2023
ankith26
ankith26 approved these changes Mar 11, 2023
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thankies 🍰

@itzpr3d4t0r itzpr3d4t0r merged commit e307345 into pygame-community:main Mar 11, 2023
@ankith26 ankith26 added this to the 2.2 milestone Mar 11, 2023
@itzpr3d4t0r itzpr3d4t0r deleted the another_minor_fblits_refactor branch March 11, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Starbuck5 Starbuck5 Starbuck5 approved these changes

@ankith26 ankith26 ankith26 approved these changes

Assignees

No one assigned

Labels

Code quality/robustness Code quality and resilience to changes Surface pygame.Surface

Projects

None yet

Milestone

2.2

Development

Successfully merging this pull request may close these issues.

3 participants

@itzpr3d4t0r @Starbuck5 @ankith26