Skip to content

Add 'stubcheck' into setup.py #1866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MyreMylar merged 3 commits into from
Feb 17, 2023
Merged

Add 'stubcheck' into setup.py #1866

MyreMylar merged 3 commits into from
Feb 17, 2023

Conversation

@yunline
Copy link
Contributor

@yunline yunline commented Feb 15, 2023

Example:

PS X:\github小项目\pygame-ce> py .\setup.py stubcheck
running stubcheck
Using python: C:\Users\yunline\AppData\Local\Programs\Python\Python310\python.exe
Success: no issues found in 210 modules
PS X:\github小项目\pygame-ce>

@yunline yunline requested a review from a team as a code owner February 15, 2023 05:40
ankith26
ankith26 reviewed Feb 15, 2023
View reviewed changes
Copy link
Member

@ankith26 ankith26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! 🎉

Left a small review. Additionally (minor nitpick), you can change the subprocess.call to subprocess.run which is the newer API

MyreMylar
MyreMylar approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@MyreMylar MyreMylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@yunline yunline requested a review from ankith26 February 15, 2023 06:53
@MightyJosip MightyJosip added Code quality/robustness Code quality and resilience to changes type hints Type hint checking related tasks and removed Code quality/robustness Code quality and resilience to changes labels Feb 15, 2023
oddbookworm
oddbookworm approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@oddbookworm oddbookworm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MyreMylar MyreMylar added this to the 2.1.4 milestone Feb 17, 2023
@MyreMylar MyreMylar merged commit 81f43a8 into pygame-community:main Feb 17, 2023
@yunline yunline deleted the setup.py branch February 17, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MyreMylar MyreMylar MyreMylar approved these changes

@oddbookworm oddbookworm oddbookworm approved these changes

@ankith26 ankith26 Awaiting requested review from ankith26

Assignees

No one assigned

Labels

type hints Type hint checking related tasks

Projects

None yet

Milestone

2.1.4

Development

Successfully merging this pull request may close these issues.

5 participants

@yunline @MyreMylar @ankith26 @oddbookworm @MightyJosip