Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlearned skills not listed as Module Skills #2102

Open
RoadieRich opened this issue Dec 11, 2019 · 4 comments
Open

Unlearned skills not listed as Module Skills #2102

RoadieRich opened this issue Dec 11, 2019 · 4 comments
Labels
bug Confirmed to be a bug

Comments

@RoadieRich
Copy link

Feature Request

Skills a character has not learned do not show in "Change Module Skills" context menu. Ideally they could be shown with a distinguishing icon.

Expected behavior:

All skills, learned or not, would show in menu

Actual behavior:

Only known skills show

Detailed steps to reproduce:

(For example)

  1. Create new character in pyfa
  2. Create (or load) fit with turrets
  3. Right click a turret > Change Module Skills
  4. Observe that Advanced Weapon Upgrades is not listed, even though it can affect the selected module

Fits involved in EFT format (Edit > To Clipboard > EFT):

N/A

Release or development git branch? Please note the release version or commit hash:

Release 2.15.1

Operating system and version (eg: Windows 10, OS X 10.9, OS X 10.11, Ubuntu 16.10):

Windows 10

@DarkFenX
Copy link
Member

Seems to be duplicate of #713. This is known limitation I am unsure we will be able to work around. Unless we just express "unlearned" as "skill level 0", which might be very different in some circumstances. As an example - compensation skills used to multiply passive resistance gain from invulns. You had base 3% if skill was not learned, and 3% * skill level if it was learned (so 0 if skill was 0 lvl). Unsure if there're such examples now, though.

@DarkFenX DarkFenX added the bug Confirmed to be a bug label Dec 12, 2019
@fonsuiplaysvideogames
Copy link
Contributor

Technically, skills have 7 states - not injected, injected but not trained, and trained to levels 1, 2, 3, 4, and 5. Perhaps representing these as level "negative one" through "five" would make this practical? Or, for the purposes of this application, simply level zero would suffice since this is not an application that cares about training in this particular manner.

@WatchMeCalculate
Copy link
Contributor

WatchMeCalculate commented Apr 17, 2020

Has something changed? I test on vers 2.20.2 on OSX and windows 10 following the steps above and I saw Advanced Weapons Upgrade: "Not Learned"

@DarkFenX
Copy link
Member

I do not remember changing anything relevant. Even if I did, I for sure did not target this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed to be a bug
Projects
None yet
Development

No branches or pull requests

4 participants