Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store relative mutated item values instead of absolute #2095

Open
DarkFenX opened this issue Nov 26, 2019 · 2 comments
Open

Store relative mutated item values instead of absolute #2095

DarkFenX opened this issue Nov 26, 2019 · 2 comments
Labels
bug Confirmed to be a bug

Comments

@DarkFenX
Copy link
Member

DarkFenX commented Nov 26, 2019

Today CCP deployed expansion which changed ADC active ability duration. With it, durations of rolled ADCs changed as well.

However, they did not change in pyfa, as they are stored as absolute value. We should change it to be relative to fix that, but there are several ways:

  • store multiplier of modified value/base value
  • store unified "roll value" in range of [0, 1]
  • store "good/bad" bit and roll value within good/bad range

They should behave the same way if base value of item changes in some EVE update, and differently if mutaplasmid roll range is changed.

@DarkFenX DarkFenX added the bug Confirmed to be a bug label Nov 26, 2019
@DarkFenX
Copy link
Member Author

for example, ADC with duration of 100, unstable mutaplasmid -15%..+35%, rolled value of 120.

  1. the value is stored as 120 / 100 = 1.2
  2. the value stored is (15 + (120 / 100 - 1) * 100) / (15 + 35) = 0.7
  3. stored as positive flag, (120 / 100 - 1) * 100 / 35 = 0.5714

If base duration is nerfed to 50, they will change modified value to:

  1. 50*1.2 = 60
  2. ((0.7 * (15 + 35) - 15) / 100 + 1) * 50 = 60
  3. (0.5714 * 35 / 100 + 1) * 50 = 60

So they all work the same when base value is changed. However they work very different if mutation range changes, say, from -15%..+35% to +15%..+115%, with base value being 100:

  1. 100 * 1.2 = 120
  2. ((0.7 * (115 − 15) + 15) / 100 + 1) * 100 = 185
  3. fucked up in my last formula but in this conversion result should be 115 + 0.5714 * 100 = 172.14

@DarkFenX
Copy link
Member Author

DarkFenX commented Nov 27, 2019

CCP Larrikin found the dev who did this part, CCP Signal, and CCP Signal explained that values are stored on scale of [0..1] (with 0 being min of mutaplasmid modification range and 1 being max of mutaplasmid modification range). That's how we will have to reimplement it too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed to be a bug
Projects
None yet
Development

No branches or pull requests

1 participant