Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph window broken since 1.6.0 #197

Closed
mmaucher opened this issue Nov 10, 2014 · 5 comments
Closed

Graph window broken since 1.6.0 #197

mmaucher opened this issue Nov 10, 2014 · 5 comments

Comments

@mmaucher
Copy link

The x and y axis in the graph window only show a range from 0 to 1 since version 1.6.0.
This behavior can be observed on Windows, Linux and Mac.

In 1.5.1, after loading a fit and opening the graph window:
screen shot 2014-11-10 at 11 21 48

In 1.6.0, after doing exactly the same:
screen shot 2014-11-10 at 11 29 49

Weapons were loaded and drones selected both times.
Filling in a signature radius doesn't help.

@DarkFenX
Copy link
Member

Can you paste example fit which has this issue? I do not have similar issues on linux and i don't think we changed anything which can affect graph functionality.

It looks like fetching data for graph simply crashes, thus i guess it should be fit-specific.

@mmaucher
Copy link
Author

When I draw a new fitting into the window, there is a warning in the bar below saying "Invalid values in " for a short time (just a few milliseconds).

Some frigate and destroyer fits actually work, but most of my fittings don't show in the graph. Screenshots in my first post were made directly before and after a Pyfa update on my Mac.

Here an example build that doesn't show in the graph:

[Vexor Navy Issue, PvE sniper]

Drone Damage Amplifier II
Drone Damage Amplifier II
Drone Damage Amplifier II
Damage Control II
Energized Adaptive Nano Membrane II
Medium Armor Repairer II

Experimental 10MN Afterburner I
Omnidirectional Tracking Link II
Omnidirectional Tracking Link II
F-90 Positional Sensor Subroutines

Drone Link Augmentor I
250mm Compressed Coil Gun I, Antimatter Charge M
250mm Compressed Coil Gun I, Antimatter Charge M
[Empty High slot]

Medium Anti-Explosive Pump I
Medium Processor Overclocking Unit I
Medium Auxiliary Nano Pump I

Garde I x5
Hobgoblin II x5
Hammerhead II x5
Iron Charge M x1
Targeting Range Script x1

@DarkFenX
Copy link
Member

Okay, drones seem to cause this issue + recent changes in resistance profile stuff. Traceback is following:

Traceback (most recent call last):
  File "/home/dfx/src/eve/pyfa/gui/mainFrame.py", line 644, in openGraphFrame
    self.graphFrame = GraphFrame(self)
  File "/home/dfx/src/eve/pyfa/gui/graphFrame.py", line 113, in __init__
    self.select(0)
  File "/home/dfx/src/eve/pyfa/gui/graphFrame.py", line 183, in select
    self.draw()
  File "/home/dfx/src/eve/pyfa/gui/graphFrame.py", line 193, in draw
    success, status = view.getPoints(fit, values)
  File "/home/dfx/src/eve/pyfa/gui/builtinGraphs/fitDps.py", line 88, in getPoints
    for point, val in fitDps.getIterator():
  File "/home/dfx/src/eve/pyfa/eos/graph/__init__.py", line 53, in _iterator
    yield point, self.function(point)
  File "/home/dfx/src/eve/pyfa/eos/graph/fitDps.py", line 71, in calcDps
    dps, _ =  drone.damageStats(fit.targetResists)
TypeError: 'float' object is not iterable

It seems to be related to fix for issue #180 - it broke graphs with drones. I will wait for blitzmann to comment on this, maybe what i was going to do could break that fix.

DarkFenX added a commit that referenced this issue Nov 10, 2014
@DarkFenX
Copy link
Member

Actually nvm, i will just change what graphs expect to fetch from drones.

@blitzmann
Copy link
Collaborator

@blitzmann blitzmann reopened this Dec 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants