Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export options take too much space #1872

Closed
DarkFenX opened this issue Mar 9, 2019 · 4 comments
Closed

Export options take too much space #1872

DarkFenX opened this issue Mar 9, 2019 · 4 comments
Labels
bug Confirmed to be a bug fixed This issue has been fixed! Oh joy! invalid Issues that are opened but aren't really issues are normally marked as invalid (usually user error) upstream Seems to be related to a dependency or third party that pyfa uses, not directly related to pyfa

Comments

@DarkFenX
Copy link
Member

DarkFenX commented Mar 9, 2019 •
edited
Loading

Debian Testing x86-64
Pyfa from price_optimize branch (commit 22fc6cb)
Xorg, GNOME 3 with standard theme, 3840x2160 with 200% UI scaling
Python 3.7.2
wxPython version: 4.0.4 (wxWidgets 3.0.4) from debian repos

When several formats specify export options, sizer with export options takes height of the tallest export option sizer. I.e. if one format has 4 options and another 3, both will have height of 4 "rows".

image
(notice how EFT section has much more padding between options)

This bug appears with proportion attribute of these sizers set to 1 (commit d2b306d changed them to 0 as temporary workaround).
@DarkFenX DarkFenX added bug Confirmed to be a bug upstream Seems to be related to a dependency or third party that pyfa uses, not directly related to pyfa labels Mar 9, 2019
@DarkFenX
Copy link
Member Author

DarkFenX commented Mar 9, 2019

Filled upstream bug as wxWidgets/Phoenix#1181

@DarkFenX DarkFenX mentioned this issue Mar 9, 2019
Open
@blitzmann
Copy link
Collaborator

@DarkFenX I think we determined this to be a proportion issue with the sizer? Can we mark this as fixed, or was there something else broken about it that I'm forgetting lol

@DarkFenX
Copy link
Member Author

Just my understanding is broken. I thought that sizers will scale to window size proportionally to its contents, but apparently not.

@DarkFenX DarkFenX added the invalid Issues that are opened but aren't really issues are normally marked as invalid (usually user error) label Mar 18, 2019
@blitzmann blitzmann reopened this Mar 19, 2019
@blitzmann blitzmann added the fixed This issue has been fixed! Oh joy! label Mar 19, 2019
@blitzmann
Copy link
Collaborator

Closing this as it related to an issue that presented after latest release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Confirmed to be a bug fixed This issue has been fixed! Oh joy! invalid Issues that are opened but aren't really issues are normally marked as invalid (usually user error) upstream Seems to be related to a dependency or third party that pyfa uses, not directly related to pyfa
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DarkFenX @blitzmann