Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to open character editor window from character selector menu #117

Closed
DarkFenX opened this issue Jun 3, 2014 · 3 comments
Closed

Comments

@DarkFenX
Copy link
Member

DarkFenX commented Jun 3, 2014

This request came from russian forums. Mockup is attached to post:

http://forum.eve-ru.com/index.php?showtopic=30521&p=2688039

This is not must-have but topic for discussion - some users have hard time with finding character editor.

@blitzmann
Copy link
Collaborator

I think it's brilliant. I'll look into it

@blitzmann
Copy link
Collaborator

This seems to be trivial.

We will need to keep a cache of the selection so that when we select "Edit Characters" we can select the old selection. This works fine, and spawning the character editor shouldn't be difficult at all.

My biggest question: how to display it. Unfortunately, wxPython does not offer a separator like it does for menus. So, although that thin line in the mock-up is sexy, I don't see how this can be achieved. However, I think simply appending "Edit Characters" looks ugly and doesn't separate it from it's purpose.

So, we can have one of 3 things:

  1. Simply append it. This looks ugly. See:
    append
  2. Add faux-separator. This looks nice.
    append
  3. Make an identifier for the selection. This also looks nice:
    append

@blitzmann
Copy link
Collaborator

Talked with a couple of people, and decided to go with the third option and renamed "Edit Characters" to "Open Character Editor". Works well =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants