Skip to content

Commit 06e8734

Browse files
committed
✨ embed the chart in html page
1 parent 0a04411 commit 06e8734

File tree

1 file changed

+14
-12
lines changed

1 file changed

+14
-12
lines changed

pyexcel_echarts/echarts.py

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,12 @@
66

77

88
class Chart(Renderer):
9-
def render_sheet(self, sheet, chart_type='bar',
10-
embed=False, **keywords):
9+
def render_sheet(self, sheet, chart_type='bar', embed=False, **keywords):
1110
charter = MANAGER.get_a_plugin(chart_type)
1211
chart_instance = charter.render_sheet(
1312
sheet, **keywords)
1413

15-
self._write_content(chart_instance)
14+
self._write_content(chart_instance, embed)
1615

1716
with tempfile.NamedTemporaryFile(suffix=".html") as fout:
1817
chart_instance.render(path=fout.name)
@@ -23,13 +22,16 @@ def render_book(self, book, chart_type='bar', embed=False, **keywords):
2322
charter = MANAGER.get_a_plugin(chart_type)
2423
chart_instance = charter.render_book(book,
2524
**keywords)
26-
self._write_content(chart_instance)
25+
self._write_content(chart_instance, embed)
2726

28-
def _write_content(self, instance):
29-
with tempfile.NamedTemporaryFile(suffix=".html") as fout:
30-
instance.render(path=fout.name)
31-
fout.seek(0)
32-
if PY2:
33-
self._stream.write(fout.read())
34-
else:
35-
self._stream.write(fout.read().decode('utf-8'))
27+
def _write_content(self, instance, embed):
28+
if embed:
29+
content = instance.render_embed()
30+
else:
31+
with tempfile.NamedTemporaryFile(suffix=".html") as fout:
32+
instance.render(path=fout.name)
33+
fout.seek(0)
34+
content = fout.read()
35+
if not PY2:
36+
content = content.decode('utf-8')
37+
self._stream.write(content)

0 commit comments

Comments
 (0)