Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded parameter is excluded from links href #1432

Open
sp628193 opened this issue Jan 12, 2021 · 1 comment
Open

Embedded parameter is excluded from links href #1432

sp628193 opened this issue Jan 12, 2021 · 1 comment
Labels

Comments

@sp628193
Copy link

sp628193 commented Jan 12, 2021

Expected Behavior

Make a request to an endpoint with embedded specified in the query string.

I would expect the parameter to be present in the various href's available in _links.

curl localhost/endpoint?embedded={"doc":1}
{
  ...,
  "_links": {
    "parent": {"title": "home", "href": "/"}, 
    "self": {"title": "endpoint", "href": "endpoint?embedded{\"doc\":1}"}
  }
}

Actual Behavior

The parameter is excluded from the href. This also seems to be the case for projection based on the various calls to this function (untested)

q = querydef(req.max_results, req.where, req.sort, version, req.page, other_params)

This results in the next href in _links being unusable when looping through paginated responses without manually adding in the additional query for every page

curl localhost/endpoint?embedded={"doc":1}
{
  ...,
  "_links": {
    "parent": {"title": "home", "href": "/"}, 
    "self": {"title": "endpoint", "href": "endpoint"}
  }
}

Environment

  • Python version: 3.9.1
  • Eve version: 1.1.4
@stale
Copy link

stale bot commented Apr 16, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant