Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some updates to pyproject.toml formatting and ruff rules #21

Merged
merged 7 commits into from
Oct 31, 2023

Conversation

tlambert03
Copy link
Contributor

mostly formatting, but also adds:

@tlambert03 tlambert03 requested a review from jdeschamps October 28, 2023 12:35
@jdeschamps
Copy link
Member

Sounds good, love the type checking!

Why deactivate tidy-import by default?

@tlambert03
Copy link
Contributor Author

Oh I don't know 😂 I guess hesitant to be too draconian since that one is more opinionated by banning deep relative imports. But I guess there's plenty of opinion in here already. Would you just enable it?

@jdeschamps
Copy link
Member

It's tough to define the threshold for "too opinionated". 😄

But the rule is autofixable and should not make non-specialists tear their hair out, so I'd have a tendency to include it.

@tlambert03
Copy link
Contributor Author

did it :)

@jdeschamps
Copy link
Member

jdeschamps commented Oct 31, 2023

Cool!

One note: in pyproject.toml, there is a typo: use_precommit should be use_pre_commit!

@tlambert03 tlambert03 merged commit 5497ed7 into pydev-guide:main Oct 31, 2023
12 checks passed
@tlambert03 tlambert03 deleted the ruff-rules branch October 31, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants