Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid converting custom indexes to pandas indexes when formatting coordinate diffs #9157

Merged
merged 6 commits into from
Jul 5, 2024
Merged

avoid converting custom indexes to pandas indexes when formatting coordinate diffs #9157

merged 6 commits into from
Jul 5, 2024

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented Jun 23, 2024 •
edited
Loading

This would attempt to convert custom indexes to pandas indexes (by calling .indexes instead of .xindexes), which for some implementations may raise.

(I need this for xarray-contrib/pint-xarray#163)

@TomNicholas
Copy link
Member

Will this fix #5812? Or not quite yet?

@keewis
Copy link
Collaborator Author

keewis commented Jun 24, 2024 •
edited
Loading

not yet, no. This just makes sure that the formatting of the coordinates representation does not call .indexes.

@keewis keewis changed the title don't convert to pandas indexes when computing a diff avoid converting custom indexes to pandas when formatting diffs Jun 24, 2024
@keewis keewis changed the title avoid converting custom indexes to pandas when formatting diffs avoid converting custom indexes to pandas indexes when formatting coordinate diffs Jun 24, 2024
dcherian
dcherian approved these changes Jun 30, 2024
View reviewed changes
Copy link
Contributor

@dcherian dcherian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcherian dcherian added the plan to merge Final call for comments label Jun 30, 2024
@dcherian dcherian merged commit 52a7371 into pydata:main Jul 5, 2024
28 checks passed
@keewis keewis deleted the index-diff branch July 7, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcherian dcherian dcherian approved these changes

Assignees
No one assigned
Labels
plan to merge Final call for comments
Projects
Explicit Indexes
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keewis @TomNicholas @dcherian