Skip to content

Don't allow overwriting indexes with region writes #8877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 27, 2024
Merged

Don't allow overwriting indexes with region writes #8877

merged 3 commits into from
Mar 27, 2024

Conversation

dcherian
Copy link
Contributor

@dcherian dcherian commented Mar 25, 2024 •
edited
Loading

cc @slevang

@dcherian dcherian requested review from max-sixty and shoyer March 25, 2024 18:13
max-sixty
max-sixty approved these changes Mar 26, 2024
View reviewed changes
Copy link
Collaborator

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea, thanks!

@dcherian dcherian added the plan to merge Final call for comments label Mar 26, 2024
@dcherian dcherian merged commit cf36559 into pydata:main Mar 27, 2024
@dcherian dcherian deleted the no-index-region-write branch March 27, 2024 16:24
dcherian added a commit to dcherian/xarray that referenced this pull request Apr 2, 2024
@dcherian
Merge branch 'main' into state-machine
4399d96 
* main: (26 commits)
  [pre-commit.ci] pre-commit autoupdate (pydata#8900)
  Bump the actions group with 1 update (pydata#8896)
  New empty whatsnew entry (pydata#8899)
  Update reference to 'Weighted quantile estimators' (pydata#8898)
  2024.03.0: Add whats-new (pydata#8891)
  Add typing to test_groupby.py (pydata#8890)
  Avoid in-place multiplication of a large value to an array with small integer dtype (pydata#8867)
  Check for aligned chunks when writing to existing variables (pydata#8459)
  Add dt.date to plottable types (pydata#8873)
  Optimize writes to existing Zarr stores. (pydata#8875)
  Allow multidimensional variable with same name as dim when constructing dataset via coords (pydata#8886)
  Don't allow overwriting indexes with region writes (pydata#8877)
  Migrate datatree.py module into xarray.core. (pydata#8789)
  warn and return bytes undecoded in case of UnicodeDecodeError in h5netcdf-backend (pydata#8874)
  groupby: Dispatch quantile to flox. (pydata#8720)
  Opt out of auto creating index variables (pydata#8711)
  Update docs on view / copies (pydata#8744)
  Handle .oindex and .vindex for the PandasMultiIndexingAdapter and PandasIndexingAdapter (pydata#8869)
  numpy 2.0 copy-keyword and trapz vs trapezoid (pydata#8865)
  upstream-dev CI: Fix interp and cumtrapz (pydata#8861)
  ...
@slevang slevang mentioned this pull request Apr 2, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhamman jhamman jhamman approved these changes

@max-sixty max-sixty max-sixty approved these changes

@shoyer shoyer Awaiting requested review from shoyer

+1 more reviewer

@slevang slevang slevang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

plan to merge Final call for comments

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Don't overwrite indexes for region writes, always

4 participants

@dcherian @jhamman @max-sixty @slevang