Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug for categorical pandas index with categories with EA dtype #8481

Merged
merged 3 commits into from
Nov 24, 2023

Conversation

phofl
Copy link
Contributor

@phofl phofl commented Nov 23, 2023

  • Tests added
  • User visible changes (including notable bug fixes) are documented in whats-new.rst

This will become a lot more common when we start inferring strings as arrow backed strings in pandas

Co-authored-by: Illviljan <14371165+Illviljan@users.noreply.github.com>
@dcherian
Copy link
Contributor

Great thanks @phofl

@dcherian dcherian merged commit dc66f0d into pydata:main Nov 24, 2023
28 checks passed
@phofl phofl deleted the categorical_string branch November 24, 2023 23:27
dcherian added a commit to rabernat/xarray that referenced this pull request Nov 29, 2023
* upstream/main:
  Raise an informative error message when object array has mixed types (pydata#4700)
  Start renaming `dims` to `dim` (pydata#8487)
  Reduce redundancy between namedarray and variable tests (pydata#8405)
  Fix Zarr region transpose (pydata#8484)
  Refine rolling_exp error messages (pydata#8485)
  Use numbagg for `ffill` by default (pydata#8389)
  Fix bug for categorical pandas index with categories with EA dtype (pydata#8481)
  Improve "variable not found" error message (pydata#8474)
  Add whatsnew for pydata#8475 (pydata#8478)
  Allow `rank` to run on dask arrays (pydata#8475)
  Fix mypy tests (pydata#8476)
  Use concise date format when plotting (pydata#8449)
  Fix `map_blocks` docs' formatting (pydata#8464)
  Consolidate `_get_alpha` func (pydata#8465)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants