Add keep_variables keyword to open_dataset() #8450
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #895 by @tsupinie, following the suggestions on that PR made by @shoyer, but that was so old I decided it was best to do a completely new PR. XArray has changed quite a bit since then, so I had to make changes in several more files than the original PR did in order to get tests to pass.
I'm very new to working on XArray, and my approach here was to basically just mirror how the package handles
drop_variables
wherever that appears, with the necessary logical tweaks where appropriate. As such I've possibly touched something that shouldn't be (in particular I'm looking atxarray/backends/zarr.py
andxarray/backends/common.py
as places where I'm not quite sure if I've done things properly).drop_variables
option inopen_dataset()
#1754whats-new.rst
api.rst