Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added driver parameter for h5netcdf #8360

Merged
merged 11 commits into from
Nov 15, 2023
Merged

Added driver parameter for h5netcdf #8360

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4fef619
added driver for h5netcdf
zequihg50 Oct 23, 2023
4ba3bb0
Update xarray/backends/h5netcdf_.py
zequihg50 Nov 13, 2023
6a1db94
Update xarray/backends/h5netcdf_.py
zequihg50 Nov 13, 2023
1f2a98e
Update xarray/backends/h5netcdf_.py
zequihg50 Nov 13, 2023
7a4978c
Update xarray/backends/h5netcdf_.py
zequihg50 Nov 13, 2023
d00b803
added test for h5netcdf ros3
zequihg50 Nov 13, 2023
5e43a58
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 13, 2023
e58350b
check h5netcdf 1.3.0 available for test
zequihg50 Nov 14, 2023
633ebed
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 14, 2023
75d6aa6
Merge remote-tracking branch 'origin/main'
zequihg50 Nov 15, 2023
190d7d4
updated doc/whats-new.rst
zequihg50 Nov 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions xarray/backends/h5netcdf_.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ def open(
invalid_netcdf=None,
phony_dims=None,
decode_vlen_strings=True,
driver=None,
zequihg50 marked this conversation as resolved.
Show resolved Hide resolved
):
import h5netcdf

Expand All @@ -161,6 +162,7 @@ def open(
kwargs = {
"invalid_netcdf": invalid_netcdf,
"decode_vlen_strings": decode_vlen_strings,
"driver": driver,
kmuehlbauer marked this conversation as resolved.
Show resolved Hide resolved
}
zequihg50 marked this conversation as resolved.
Show resolved Hide resolved
if phony_dims is not None:
kwargs["phony_dims"] = phony_dims
Expand Down Expand Up @@ -397,6 +399,7 @@ def open_dataset( # type: ignore[override] # allow LSP violation, not supporti
invalid_netcdf=None,
phony_dims=None,
decode_vlen_strings=True,
driver=None,
zequihg50 marked this conversation as resolved.
Show resolved Hide resolved
) -> Dataset:
filename_or_obj = _normalize_path(filename_or_obj)
store = H5NetCDFStore.open(
Expand All @@ -407,6 +410,7 @@ def open_dataset( # type: ignore[override] # allow LSP violation, not supporti
invalid_netcdf=invalid_netcdf,
phony_dims=phony_dims,
decode_vlen_strings=decode_vlen_strings,
driver=driver,
zequihg50 marked this conversation as resolved.
Show resolved Hide resolved
)

store_entrypoint = StoreBackendEntrypoint()
Expand Down
Loading