test_interpolate_pd_compat with range of fill_value's #8189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmuehlbauer
force-pushed
the
missing-fill_value-tests
branch
from
3fd9a72 to
8693acb
Compare
|
@max-sixty I've adapted the test to take fill_value into account and left some additional information on pandas' peculiarities. The upstream errors are unrelated. Would be great if you can review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update: The enhanced test works well in Upstream-dev tests, Pandas 2.1.1 is available for safe merge.
whats-new.rstapi.rst