-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
initial refactor for NamedArray #8075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Should we use |
the advantage is that the package name on PyPI / conda-forge would be the same as the import name |
|
Also it's ironic that our |
Co-authored-by: Illviljan <14371165+Illviljan@users.noreply.github.com>
Co-authored-by: Illviljan <14371165+Illviljan@users.noreply.github.com> Co-authored-by: Deepak Cherian <dcherian@users.noreply.github.com>
for more information, see https://pre-commit.ci
|
this initial prototype is ready for another round of review. however, there is still a significant amount of work that needs to be done we are keeping track of all the tasks in this project board. for those who are interested in following along or contributing, you can find the project board here: Link |
Co-authored-by: Illviljan <14371165+Illviljan@users.noreply.github.com>
for more information, see https://pre-commit.ci
|
Thanks for adding the tests @andersy005 . Let's move forward here. |
this pull request introduces the initial prototype for
NamedArrayas discussed in issue #8073. the intention is to approach the implementation in multiple phases through separate pull requests. the main objectives of this PR are as follows:creation of a new class,
xarray.named_array.NamedArray, which will encompass most of the necessary functionality for the lightweight version ofxarray.Variable. As a result,xarray.Variablewill inherit from this class and implement specific functionality related to xarray.removal of all imports of internal Xarray classes and utilities from the
xarray.named_arraysub-package. the aim is to eliminate dependencies on anything withinxarray.core. This will facilitate the future goal of movingnamed_arrayinto its own standalone package, withxarraythen depending on it.whats-new.rstapi.rst