Skip to content

Fix concat with scalar coordinate (wrong index type) #6443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 6, 2022
Merged

Fix concat with scalar coordinate (wrong index type) #6443

merged 2 commits into from
Apr 6, 2022

Conversation

benbovy
Copy link
Member

@benbovy benbovy commented Apr 5, 2022

@dcherian
Copy link
Contributor

dcherian commented Apr 6, 2022 •
edited
Loading

Nice. thanks @benbovy

This fixes the cf_xarray tests.

@dcherian dcherian merged commit facafac into pydata:main Apr 6, 2022
@benbovy benbovy deleted the fix-concat-scalar-dtype-erased branch December 8, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

concat along dim with mix of scalar coordinate and array coordinates is not right
2 participants
@benbovy @dcherian