Skip to content

Remove lock kwarg #5912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 29, 2021
Merged

Remove lock kwarg #5912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9da74e3
removed lock kwarg from zarra backend
TomNicholas Oct 28, 2021
d4e5b74
remove lock kwarg from pydap backend
TomNicholas Oct 28, 2021
6c9e8ac
whatsnew
TomNicholas Oct 28, 2021
40e2a45
Merge branch 'main' into pr/5912
Illviljan Dec 29, 2021
ce266b5
Update whats-new.rst
Illviljan Dec 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions doc/whats-new.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ Breaking changes

Deprecations
~~~~~~~~~~~~
- Removed the lock kwarg from the zarr and pydap backends, completing the deprecation cycle started in :issue:`5256`.
By `Tom Nicholas <https://github.com/TomNicholas>`_.


Bug fixes
Expand Down
10 changes: 0 additions & 10 deletions xarray/backends/pydap_.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import warnings

import numpy as np

from ..core import indexing
Expand Down Expand Up @@ -126,15 +124,7 @@ def open_dataset(
use_cftime=None,
decode_timedelta=None,
session=None,
lock=None,
):
# TODO remove after v0.19
if lock is not None:
warnings.warn(
"The kwarg 'lock' has been deprecated for this backend, and is now "
"ignored. In the future passing lock will raise an error.",
DeprecationWarning,
)

store = PydapDataStore.open(
filename_or_obj,
Expand Down
8 changes: 0 additions & 8 deletions xarray/backends/zarr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -810,15 +810,7 @@ def open_dataset(
chunk_store=None,
storage_options=None,
stacklevel=3,
lock=None,
):
# TODO remove after v0.19
if lock is not None:
warnings.warn(
"The kwarg 'lock' has been deprecated for this backend, and is now "
"ignored. In the future passing lock will raise an error.",
DeprecationWarning,
)

filename_or_obj = _normalize_path(filename_or_obj)
store = ZarrStore.open_group(
Expand Down