Merged
Conversation
Contributor
Contributor
|
This makes sense to me. These attributes more fully describe the independent variable. They were added due to a lack of clarity and to allow better unit handling on the independent variable. Thank you for updating the test. |
Collaborator
Author
|
Thanks for the feedback - so I suggest to merge soonish as this breaks the tests on main. |
2 tasks
Contributor
|
Looks good to me. Shall we merge? |
Collaborator
Author
|
Jup, let's merge. Thanks! |
dcherian
added a commit
to dcherian/xarray
that referenced
this pull request
Oct 23, 2021
* upstream/main: fix test with pseudonetcdf 3.2 (pydata#5875)
snowman2
pushed a commit
to snowman2/xarray
that referenced
this pull request
Feb 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes one part of #5872
pseudoNETCDF adds two attrs to ict files, which breaks the following two tests:
Test 1:
xarray/xarray/tests/test_backends.py
Line 3944 in 07de257
Test 2:
xarray/xarray/tests/test_backends.py
Line 4030 in 07de257
I reproduced the test file so that the tests pass again. To reproduce the file I used the following bit of code:
The
savemethod is here:xarray/xarray/tests/test_backends.py
Line 4124 in 07de257
@barronh I would appreciate your review here - I am not sure if this is the right approach.