Remove use of deprecated kind argument in CFTimeIndex tests
#5723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencerkclark
changed the title
CFTimeIndex testskind argument in CFTimeIndex tests
|
LGTM - I think the test failure does not come from here? |
|
That's right. I now merged |
|
Oops I forgot about the minimum deps environment. Those failures are indeed real. I guess we could put some version-dependent logic in there. |
Closed
|
@mathause I think this should be ready now. I added some version-dependent logic to the tests. |
|
Thanks @spencerkclark |
dcherian
added a commit
to dcherian/xarray
that referenced
this pull request
Oct 29, 2021
* upstream/main: Only run asv benchmark when labeled (pydata#5893) Add asv benchmark jobs to CI (pydata#5796) Remove use of deprecated `kind` argument in `CFTimeIndex` tests (pydata#5723) Single matplotlib import (pydata#5794) Check jupyter nbs with black in pre-commit (pydata#5891)
snowman2
pushed a commit
to snowman2/xarray
that referenced
this pull request
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the topic of FutureWarning's related to indexing in pandas (#5721), I noticed some another kind of warning in the
CFTimeIndextests:I think it's safe to silence these by removing the
kindargument from these tests. We never used it anyway inCFTimeIndex. This is sort of a follow-up to #5359.pre-commit run --all-fileswhats-new.rst