Roll coords deprecation #5653
Merged
Roll coords deprecation #5653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TomNicholas typing should be fixed! |
mathause
approved these changes
Aug 2, 2021
Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com>
Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com>
Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com>
Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com>
Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com>
|
Thank you very much @max-sixty and @mathause ! I think this should be ready to merge now. |
mathause
reviewed
Aug 5, 2021
|
@TomNicholas shall we merge? |
snowman2
pushed a commit
to snowman2/xarray
that referenced
this pull request
Feb 9, 2022
* changed default * updated tests * updated whats-new * Fix mypy * Update xarray/core/dataarray.py Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com> * Update xarray/core/dataarray.py Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com> * Update xarray/core/dataarray.py Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com> * Update xarray/core/dataset.py Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com> * Update xarray/core/dataset.py Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com> * tidy up specification of default argument in docstring * isort linting * Update xarray/core/indexes.py Co-authored-by: Maximilian Roos <m@maxroos.com> Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com> Co-authored-by: Deepak Cherian <dcherian@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default behaviour of
da.roll()caught me out whilst trying to hand-write adifffunction, so I completed the transition to defaulting toroll_coords=Falseas the default. It's been throwing a warning for 3 years so I think it's time!I also improved the docstrings and added type hints whilst there, although mypy doesn't seem to like some of the type hinting :/
pre-commit run --all-fileswhats-new.rst