-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use _unstack_once for valid dask and sparse versions #5315
Use _unstack_once for valid dask and sparse versions #5315
Conversation
Hello @Illviljan! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-05-17 21:56:42 UTC |
pint doesn't seem to be playing nice still @max-sixty. Seems some of your issues from #4746 are still there? Eventhough some of the issues in #4751 seems to have been solved. |
@keewis any thoughts? One (kinda bad) idea would be to branch on whether pint was installed — presumably if it's not installed then it can't cause the import issues. But changing dask performance based on whether pint is installed is not great! |
yep, to really fix this we would have to change |
Great, that could be a good workaround. What |
@keewis any idea what it means when only 1 check has been run? |
github actions currently has "degraded performance" (earlier today it was a "major outage") |
Looks great! Let's merge on green. Feel free to add a whatsnew @Illviljan ! |
Great @Illviljan ! Feel free to add a whatsnew in a different PR — this is good news for lots of dask users |
* Revert "Use _unstack_once for valid dask and sparse versions (#5315)" This reverts commit 9165c26. * 0.18.2 release notes * fix RTD [skip-ci] (#5518) * v0.19.0 release notes * Update doc/whats-new.rst [skip-ci] * remove empty sections Co-authored-by: Maximilian Roos <m@maxroos.com> Co-authored-by: keewis <keewis@users.noreply.github.com>
pre-commit run --all-files