combine_attrs merge errors with compat="minimal" are silenced #5262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoyer
approved these changes
May 5, 2021
Member
shoyer
left a comment
shoyer
left a comment
There was a problem hiding this comment.
I agree with this change. Merging attributes should be logically separate from compat.
andersy005
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up to #4902: the way it was written, calling
xr.merge(..., combine_attrs="no_conflicts", compat="minimal")would silenceMergeError. The tests didn't catch this because I was trying to test both variables and dimension variables at the same time, and the dimension variable raised.If I'm wrong in assuming that
compat="minimal"should not interfere withcombine_attrsI guess we can close this (or remove everything except the change to raise the merge error from the value error).pre-commit run --all-files