Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve the error message for invalid hue names #5060

Merged
merged 4 commits into from
Mar 30, 2021
Merged

improve the error message for invalid hue names #5060

merged 4 commits into from
Mar 30, 2021

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented Mar 20, 2021

I chose to implement the easier fix described in #4913 (comment), but if refactoring _infer_xy_labels would be better I can do that, too.

mathause
mathause approved these changes Mar 29, 2021
View reviewed changes
Copy link
Collaborator

@mathause mathause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to go for the easy solution.

@dcherian
Copy link
Contributor

Thanks @keewis and @mathause

@dcherian dcherian merged commit 821479d into pydata:master Mar 30, 2021
@keewis keewis deleted the fix-hue-error branch March 30, 2021 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathause mathause mathause approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

plot: ValueError for invalid hue argument is confusing
3 participants
@keewis @dcherian @mathause