Add date attribute to datetime accessor #4994
Conversation
|
Hi @observingClouds — thanks for the PR, and forgive us taking a few days to review it. Without me being an expert in this area, it looks good. Could you add a test for the behavior? |
There was a problem hiding this comment.
Yes, please add test - should not be too much work. If I am not mistaken it should be enough to add "date" to the following two lists:
xarray/xarray/tests/test_accessor_dt.py
Line 45 in d4b7a60
xarray/xarray/tests/test_accessor_dt.py
Line 130 in d4b7a60
And you can find an example for another attribute that is not implemented in cftime:
xarray/xarray/tests/test_accessor_dt.py
Line 425 in d4b7a60
you can copy and adapt this for your new attribute.
There was a problem hiding this comment.
This looks good to me -- thanks @observingClouds! Could you also add core.accessor_dt.DatetimeAccessor.date to api-hidden.rst? This will make sure that, like for the other attributes, you can click on its name in the table on this page.
|
Great! @spencerkclark I added the information to |
|
Thanks @observingClouds! |
|
Thanks for this great tool and the great support! |
…indow * upstream/master: Fix regression in decoding large standard calendar times (pydata#5050) Fix sticky sidebar responsiveness on small screens (pydata#5039) Flexible indexes refactoring notes (pydata#4979) add a install xarray step to the upstream-dev CI (pydata#5044) Adds Dataset.query() method, analogous to pandas DataFrame.query() (pydata#4984) run tests on python 3.9 (pydata#5040) Add date attribute to datetime accessor (pydata#4994) 📚 New theme & rearrangement of the docs (pydata#4835) upgrade ci-trigger to the most recent version (pydata#5037) GH5005 fix documentation on open_rasterio (pydata#5021) GHA for automatically canceling previous CI runs (pydata#5025) Implement GroupBy.__getitem__ (pydata#3691) conventions: decode unsigned integers to signed if _Unsigned=false (pydata#4966) Added support for numpy.bool_ (pydata#4986) Add additional str accessor methods for DataArray (pydata#4622)
…-tasks * upstream/master: Fix regression in decoding large standard calendar times (pydata#5050) Fix sticky sidebar responsiveness on small screens (pydata#5039) Flexible indexes refactoring notes (pydata#4979) add a install xarray step to the upstream-dev CI (pydata#5044) Adds Dataset.query() method, analogous to pandas DataFrame.query() (pydata#4984) run tests on python 3.9 (pydata#5040) Add date attribute to datetime accessor (pydata#4994) 📚 New theme & rearrangement of the docs (pydata#4835) upgrade ci-trigger to the most recent version (pydata#5037) GH5005 fix documentation on open_rasterio (pydata#5021) GHA for automatically canceling previous CI runs (pydata#5025) Implement GroupBy.__getitem__ (pydata#3691) conventions: decode unsigned integers to signed if _Unsigned=false (pydata#4966) Added support for numpy.bool_ (pydata#4986) Add additional str accessor methods for DataArray (pydata#4622) add polyval to polyfit see also (pydata#5020) mention map_blocks in the docstring of apply_ufunc (pydata#5011) Switch backend API to v2 (pydata#4989) WIP: add new backend api documentation (pydata#4810) pin netCDF4=1.5.3 in min-all-deps (pydata#4982)
pre-commit run --all-fileswhats-new.rst