-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a combine_attrs option to open_mfdataset #4971
Conversation
The motivation for The current behavior is |
for the main object, yes, but for the variables of that object We might eventually want to switch both to |
I decided to change the default from I guess that means that unless the CI fails this should be ready for review / merging? |
(the RTD build fails because |
In order to fix the failing tests in #4902 we need to expose
combine_attrs
to be able to properly construct the expected result (to be passed through to the combine function).This overlaps with the fallback of the
attrs_file
code, which I removed for now. Maybecombine_attrs="override"
would be better?pre-commit run --all-files
whats-new.rst