Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isort . && black . && mypy . && flake8
Supresses 3 warnings we get in the test suite. Two are trivial. The third is
PytestUnraisableExceptionWarning: Exception ignored in: CachingFileManager.__del__
:CachingFileManager.__init__
:xarray/xarray/tests/test_backends_file_manager.py
Lines 205 to 207 in 31d540f
__del__
but there is an error because an attribute is not available (as__init__
failed)xarray/xarray/backends/file_manager.py
Line 238 in 31d540f
__del__
are ignored, therefore we get aPytestUnraisableExceptionWarning
I decided to suppress the error and not fix
CachingFileManager
as I think that's nothing user-facing...