Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop support for python 3.6 #4720

Merged
merged 17 commits into from
Jan 7, 2021
Merged

drop support for python 3.6 #4720

merged 17 commits into from
Jan 7, 2021

Conversation

keewis
Copy link
Collaborator

@keewis keewis commented Dec 21, 2020 •
edited
Loading

Following NEP-29, our dependencies have started to drop active support for python 3.6. I tried removing all mentions of py36, but I might have missed something.

Last time I checked support for python 3.9 was blocked by some dependencies, so adding that will have to wait a bit longer.

@keewis
Copy link
Collaborator Author

keewis commented Dec 21, 2020

it seems we have to update the minimum setuptools version for this, but I'm not sure which to choose. 39.2 is the last release before py37 was released, but I can't get conda (using conda-forge) to install anything below 40.4 into a environment with python=3.7.9

@mathause
Copy link
Collaborator

https://github.com/pydata/xarray/blob/master/doc/installing.rst will need to be adjusted

keewis
keewis commented Dec 22, 2020
View reviewed changes
doc/installing.rst Outdated Show resolved Hide resolved
@keewis
Copy link
Collaborator Author

keewis commented Dec 22, 2020

I will also change the whats-new.rst entry. @mathause, was there anything missing other than the setuptools version?

@mathause
Copy link
Collaborator

I think thats all.

@jhamman
Copy link
Member

jhamman commented Dec 23, 2020

LGTM. As I understand it, we don't really have a choice on the setuptools version bump. Can we temporarily disable the check on setuptools so the CI passes?

@keewis
Copy link
Collaborator Author

keewis commented Dec 26, 2020

there's a POLICY_OVERRIDE for setuptools, so I updated that.

Reading #4295 again, I'm not sure what to do about this: we don't really need to require setuptools>=40.4 because of features / bug fixes, it's just that we can't have our CI check that that version doesn't break anything (I don't expect using the pip section works). I think I will update the changelog entry to reflect that, and not update the install_requires / setup_requires entries for setuptools.

We will only be able to fully get rid of this issue once we drop support for python 3.7 and are able to switch to the stdlib importlib.* libraries (and the external entrypoints library).

This was referenced Dec 30, 2020
Merged
Merged
@keewis keewis closed this Jan 6, 2021
@keewis keewis reopened this Jan 6, 2021
@mathause
Copy link
Collaborator

mathause commented Jan 6, 2021

Do you need to update setuptools in setup.cfg?

xarray/setup.cfg

Line 79 in 31d540f

setuptools >= 38.4 # For pkg_resources

@keewis
Copy link
Collaborator Author

keewis commented Jan 6, 2021

Do you need to update setuptools in setup.cfg?

👍 we should probably keep that in sync with the environment files.

@shoyer, any opinion about the bump of setuptools beyond the maximum version available when py37 was released (see #4720 (comment))?

Otherwise this should be ready for merging.

@jhamman
Copy link
Member

jhamman commented Jan 6, 2021

My opinion on the bump of setuptools is that we don't really have a choice. If 40.4 is the minimum version that works, that's the minimum version that works. We should really just be treating the minimum version policy as a guide in cases like this. In this case, we make an exception because of incompatibility outside our control.

@jhamman
Copy link
Member

jhamman commented Jan 7, 2021

This is blocking #4730. Any objections to merging this today?

@jhamman jhamman merged commit 477e75a into pydata:master Jan 7, 2021
@keewis keewis deleted the drop-py36 branch January 7, 2021 18:39
@raybellwaves raybellwaves mentioned this pull request Jan 7, 2021
Closed
dcherian added a commit to TomNicholas/xarray that referenced this pull request Jan 18, 2021
@dcherian
Merge remote-tracking branch 'upstream/master' into integrate_dim_arg
b9c1e6f 
* upstream/master: (342 commits)
  fix decode for scale/ offset list (pydata#4802)
  Expand user dir paths (~) in open_mfdataset and to_zarr. (pydata#4795)
  add a version info step to the upstream-dev CI (pydata#4815)
  fix the ci trigger action (pydata#4805)
  scatter plot by order of the first appearance of hue (pydata#4723)
  don't skip the scheduled CI (pydata#4806)
  coords: retain str dtype (pydata#4759)
  Fix interval labels with units (pydata#4794)
  Always force dask arrays to float in missing.interp_func (pydata#4771)
  Print number of variables in repr (pydata#4762)
  install conda as a library in the minimum dependency check CI (pydata#4792)
  Migrate CI from azure pipelines to GitHub Actions (pydata#4730)
  use conda.api instead of parallel calls to the conda binary (pydata#4775)
  Speed up missing._get_interpolator (pydata#4776)
  Remove special case in guess_engines (pydata#4777)
  improve typing of OrderedSet (pydata#4774)
  CI: ignore some warnings (pydata#4773)
  DOC: update hyperlink for xskillscore (pydata#4778)
  drop support for python 3.6 (pydata#4720)
  Trigger upstream CI on cron schedule (by default) (pydata#4729)
  ...
@aulemahal aulemahal mentioned this pull request Jan 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcherian dcherian dcherian approved these changes

@jhamman jhamman jhamman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

drop python 3.6 support
4 participants
@keewis @mathause @jhamman @dcherian