Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isort to CI #3721

Merged
merged 7 commits into from
Jan 28, 2020
Merged

Add isort to CI #3721

merged 7 commits into from
Jan 28, 2020

Conversation

crusaderky
Copy link
Contributor

No description provided.

@crusaderky
Copy link
Contributor Author

Demo isort CI in action: https://github.com/pydata/xarray/pull/3721/checks?check_run_id=406904833

@crusaderky crusaderky closed this Jan 24, 2020
@crusaderky crusaderky reopened this Jan 24, 2020
@max-sixty
Copy link
Collaborator

+0.2, and we can revert if people really complain.

If there were a tool to autocorrect PRs (i.e. not just fail CI, but offer to add commits to correct the problems), that would be great

@crusaderky
Copy link
Contributor Author

@max-sixty I wouldn't 100% advise using such level of automation for isort. Have a look at the # isort:skip tags in our codebase; they're all cases where isort would otherwise break the code.

@max-sixty
Copy link
Collaborator

Yes; I'm particularly thinking of someone making their first contribution, maybe without all the linters and tools locally, and getting stymied by a slightly incorrect import.

Ofc the tool would have to respect isort:skip...

@crusaderky
Copy link
Contributor Author

@max-sixty that's what PULL_REQUEST_TEMPLATE.md is for...

@max-sixty
Copy link
Collaborator

I know, I know :)

Potentially we have different priors on whether people might get stuck on all the setup. I hope there's no one, and if there is we can decide what to do!

@max-sixty
Copy link
Collaborator

Just in case my previous comments were unclear, I think we should merge this!
(and then reassess if we get complaints, which I give ~20% likelihood)

@max-sixty
Copy link
Collaborator

Thank you @crusaderky

@dcherian
Copy link
Contributor

OK. thanks @crusaderky

@dcherian dcherian merged commit 20dd7dc into pydata:master Jan 28, 2020
dcherian added a commit to dcherian/xarray that referenced this pull request Jan 28, 2020
@dcherian
Merge remote-tracking branch 'upstream/master' into 0.15-whats-new
5fc4b08 
* upstream/master:
  Add isort to CI (pydata#3721)
@crusaderky crusaderky deleted the isort branch January 30, 2020 12:22
dcherian added a commit to dcherian/xarray that referenced this pull request Jan 31, 2020
@dcherian
Merge remote-tracking branch 'upstream/master' into groupby-plot
c83c617 
* upstream/master:
  Python 3.8 CI (pydata#3727)
  PKG: Explicitly add setuptools dependency (pydata#3628)
  update whats-new
  Typo in Universal Functions section (pydata#3663)
  Release v0.15.0
  fix setup.cfg
  Documentation fixes (pydata#3732)
  Remove extra && in PR template (pydata#3730)
  Remove garbage text inserted in DASK_LICENSE (pydata#3729)
  Avoid unsafe use of pip (pydata#3726)
  remove PR pre-black instructions (pydata#3707)
  Fix whats-new for 0.15 (pydata#3723)
  Add isort to CI (pydata#3721)
  setuptools-scm (3) (pydata#3724)
  Fix Sphinx links on contributing doc page (pydata#3710)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crusaderky @max-sixty @dcherian