Skip to content

minor lint tweaks #3429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 24, 2019
Merged

minor lint tweaks #3429

merged 8 commits into from
Oct 24, 2019

Conversation

@crusaderky
Copy link
Contributor

@crusaderky crusaderky commented Oct 22, 2019 •
edited
Loading

@crusaderky crusaderky changed the title pyflakes 2.1.1, some tweaks mypy 0.740 minor lint tweaks Oct 22, 2019
@crusaderky
Copy link
Contributor Author

crusaderky commented Oct 22, 2019

Blocked by #3426 and #3427

@max-sixty
Copy link
Collaborator

max-sixty commented Oct 22, 2019

Blocked by #3426 and #3427

Unless this is causing additional failures, I think we can still merge?

@max-sixty max-sixty self-requested a review October 22, 2019 17:00
@crusaderky
Copy link
Contributor Author

crusaderky commented Oct 22, 2019

@max-sixty the cftime issue is causing 10,440 test failures. Are you volunteering to go through them one by one to verify there aren't any new ones? :)

@dcherian
Copy link
Contributor

dcherian commented Oct 22, 2019

only upstream-dev and the minimum versions thing should fail if you merge master now

@crusaderky crusaderky merged commit 652dd3c into pydata:master Oct 24, 2019
@crusaderky crusaderky deleted the lint branch October 24, 2019 12:53
dcherian added a commit to dcherian/xarray that referenced this pull request Oct 24, 2019
@dcherian
Merge remote-tracking branch 'upstream/master' into fix/allow_lazy
4783f35 
* upstream/master:
  minor lint tweaks (pydata#3429)
  Hack around pydata#3440 (pydata#3442)
  Update Terminology page to account for multidimensional coordinates (pydata#3410)
  Use cftime master for upstream-dev build (pydata#3439)
dcherian added a commit to dcherian/xarray that referenced this pull request Oct 24, 2019
@dcherian
Merge remote-tracking branch 'upstream/master' into fix/groupby-reduc…
4d14fca 
…e-multiple-dims

* upstream/master:
  minor lint tweaks (pydata#3429)
  Hack around pydata#3440 (pydata#3442)
  Update Terminology page to account for multidimensional coordinates (pydata#3410)
  Use cftime master for upstream-dev build (pydata#3439)
dcherian added a commit to dcherian/xarray that referenced this pull request Oct 24, 2019
@dcherian
Merge remote-tracking branch 'upstream/master' into fix/groupby-nan
207e168 
* upstream/master:
  minor lint tweaks (pydata#3429)
  Hack around pydata#3440 (pydata#3442)
  Update Terminology page to account for multidimensional coordinates (pydata#3410)
  Use cftime master for upstream-dev build (pydata#3439)
dcherian added a commit to dcherian/xarray that referenced this pull request Oct 25, 2019
@dcherian
Merge remote-tracking branch 'upstream/master' into interp-na-maxgap
c12e1da 
* upstream/master:
  minor lint tweaks (pydata#3429)
  Hack around pydata#3440 (pydata#3442)
  Update Terminology page to account for multidimensional coordinates (pydata#3410)
  Use cftime master for upstream-dev build (pydata#3439)
  MAGA (Make Azure Green Again) (pydata#3436)
  Test that Dataset and DataArray resampling are identical (pydata#3412)
  Avoid multiplication DeprecationWarning in rasterio backend (pydata#3428)
  Sync with latest version of cftime (v1.0.4) (pydata#3430)
  Add cftime git tip to upstream-dev + temporarily pin cftime (pydata#3431)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@max-sixty max-sixty max-sixty approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@crusaderky @max-sixty @dcherian