Improve open_mfdataset deprecation warnings #3101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
TomNicholas
commented
Jul 12, 2019
TomNicholas
commented
- Closes auto_combine warnings with open_mfdataset #3091
- Tests added
|
Hello @TomNicholas! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2019-07-12 13:19:40 UTC |
Codecov Report
@@ Coverage Diff @@
## master #3101 +/- ##
==========================================
- Coverage 95.99% 95.99% -0.01%
==========================================
Files 63 63
Lines 12792 12796 +4
==========================================
+ Hits 12280 12283 +3
- Misses 512 513 +1 |
|
Awesome. I think this looks great. Sorry for not catching it earlier. |
|
That's perfect! Thanks @TomNicholas |
shoyer
reviewed
Jul 12, 2019
| @@ -523,7 +523,8 @@ def combine_by_coords(datasets, compat='no_conflicts', data_vars='all', | |||
|
|
|||
|
|
|||
| def auto_combine(datasets, concat_dim='_not_supplied', compat='no_conflicts', | |||
| data_vars='all', coords='different', fill_value=dtypes.NA): | |||
| data_vars='all', coords='different', fill_value=dtypes.NA, | |||
There was a problem hiding this comment.
Don't worry about it here -- it's not worth the trouble for a deprecated function -- but in the future when you want something like this the clean way to do it is probably to make a private helper function _auto_combine that adds the extra non-user-facing arguments.
|
thanks @TomNicholas ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.