Remove deprecated pytest.config usages #2988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After some testing, this doesn't change behavior. As before, it mostly works:
|
|
This looks fine to me. I don't think it's important to retain the same command for running flakey tests. |
|
OK great; I'll merge We don't test-the-tests so anyone who encounters any problems: post here and I'll prioritize |
dcherian
added a commit
to dcherian/xarray
that referenced
this pull request
May 29, 2019
* upstream/master: cfgrib is now part of conda-forge (pydata#2992) Add fill_value for concat and auto_combine (pydata#2964) Remove deprecated pytest.config usages (pydata#2988) Add transpose_coords option to DataArray.transpose (pydata#2556) Fix rolling.constuct() example (pydata#2967) Implement load_dataset() and load_dataarray() (pydata#2917)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whats-new.rstfor all changes andapi.rstfor new APII need to confirm whether this works with an installed version of xarray, because of pytest-dev/pytest#1596.
If pytest doesn't pick up this config, it will run all tests, because the default is to not skip.
I know I've generally been the point person for pytest - let me know if anyone has an immediate solution for this though