-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fill_value for concat and auto_combine #2964
Conversation
@TomNicholas looks like you'll need to add |
Yeah I saw this - that's fine. Probably best to do them as separate commits though no? Just depends which one gets merged first. If we merge mine first then I'm happy to review/adapt this PR to be compatible. |
👍. Mind giving this PR a review? You know this bit of the code well... |
This looks pretty safe to me. It's basically just threading down the |
Yeah this looks fine to me - it basically bypasses all the complicated combining logic anyway. Just to be totally explicit then changing |
This is the current default behavior for |
Thanks @zdgriffith ! |
* upstream/master: cfgrib is now part of conda-forge (pydata#2992) Add fill_value for concat and auto_combine (pydata#2964) Remove deprecated pytest.config usages (pydata#2988) Add transpose_coords option to DataArray.transpose (pydata#2556) Fix rolling.constuct() example (pydata#2967) Implement load_dataset() and load_dataarray() (pydata#2917)
This PR adds the optional
fill_value
parameter toconcat()
andauto_combine()
inxarray.core.combine
, plus the associated underlying functions in the module. This builds on the previous PR #2920 in addressing issue #2876, and gives users the option to avoid type-changing tofloat
for arrays with missing values when using these functions as discussed in issue #2870.whats-new.rst
for all changes andapi.rst
for new API