Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base classes in Python 3 don't need to subclass object #2950

Merged
merged 2 commits into from
May 9, 2019
Merged

Base classes in Python 3 don't need to subclass object #2950

merged 2 commits into from
May 9, 2019

Conversation

crusaderky
Copy link
Contributor

@crusaderky crusaderky commented May 9, 2019 •
edited
Loading

  • Fully documented, including whats-new.rst for all changes and api.rst for new API

@crusaderky
Copy link
Contributor Author

@shoyer ready for merge. The 2 failures on Windows have nothing to do with my change.

@crusaderky
Copy link
Contributor Author

Test failures discussed in #2936

@shoyer shoyer merged commit 24d49fc into pydata:master May 9, 2019
@shoyer
Copy link
Member

shoyer commented May 9, 2019

Looks good to me, thanks!

@crusaderky crusaderky deleted the py2object branch July 9, 2019 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crusaderky @shoyer